Skip to content

Conversation

@Lipata
Copy link
Member

@Lipata Lipata commented Oct 7, 2025

No description provided.

@Lipata Lipata requested a review from Copilot October 7, 2025 17:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Disables the ESLint eqeqeq rule for HTML template files in Angular projects to address linting issues in template expressions.

  • Adds eqeqeq: 'off' rule configuration for HTML files in both igx-ts and igx-ts-legacy templates
  • Updates ESLint configuration to allow loose equality operators in Angular template expressions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/igx-templates/igx-ts/projects/_base/files/eslint.config.mjs Disables eqeqeq rule for HTML files in the standard TypeScript template
packages/igx-templates/igx-ts-legacy/projects/_base/files/eslint.config.mjs Disables eqeqeq rule for HTML files in the legacy TypeScript template

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

},
{
files: ['**/*.html'],
rules: {
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: this line has an extra space compared to the standard template. Should be 4 spaces to match the pattern used in the other file.

Suggested change
rules: {
rules: {

Copilot uses AI. Check for mistakes.
@Lipata Lipata force-pushed the nalipiev/eslint-eq branch from c71ae17 to 3df0cdc Compare October 7, 2025 17:19
@Lipata Lipata requested a review from Copilot October 7, 2025 17:21
@coveralls
Copy link

coveralls commented Oct 7, 2025

Coverage Status

coverage: 70.252%. remained the same
when pulling 3df0cdc on nalipiev/eslint-eq
into 976a9bd on master.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lipata Lipata merged commit e181128 into master Oct 7, 2025
3 checks passed
@Lipata Lipata deleted the nalipiev/eslint-eq branch October 7, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants